-
Notifications
You must be signed in to change notification settings - Fork 128
Refactored fcl-core app utils folder files to TypeScript #2442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored fcl-core app utils folder files to TypeScript #2442
Conversation
|
@@ -134,7 +157,7 @@ export async function verifyAccountProof( | |||
|
|||
return query({ | |||
cadence: await getVerifySignaturesScript(ACCOUNT_PROOF, opts), | |||
args: (arg, t) => [ | |||
args: (arg: any, t: any) => [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary? If so, it seems like there might be another issue going on here. fcl.query
args should be typed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, i didn't refactor yet the exec folder that is where there is the query function!
When refactoring that, these params will be inferred from query params interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did it! Thanks
Co-authored-by: Jordan Ribbink <17958158+jribbink@users.noreply.github.com>
Closes #2441