Skip to content

Refactored fcl-core app utils folder files to TypeScript #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 11, 2025

Conversation

mfbz
Copy link
Contributor

@mfbz mfbz commented May 21, 2025

Closes #2441

@mfbz mfbz requested a review from a team as a code owner May 21, 2025 10:12
Copy link

changeset-bot bot commented May 21, 2025

⚠️ No Changeset found

Latest commit: 792726e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -134,7 +157,7 @@ export async function verifyAccountProof(

return query({
cadence: await getVerifySignaturesScript(ACCOUNT_PROOF, opts),
args: (arg, t) => [
args: (arg: any, t: any) => [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? If so, it seems like there might be another issue going on here. fcl.query args should be typed.

Copy link
Contributor Author

@mfbz mfbz May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, i didn't refactor yet the exec folder that is where there is the query function!
When refactoring that, these params will be inferred from query params interface

Copy link
Contributor

@jribbink jribbink May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, gotcha. Should have clarified - it's already typed through the JSDoc.

I just checked myself and you're able to remove the any annotations with no type errors here.

Screenshot 2025-05-23 at 12 01 00 AM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it! Thanks

Co-authored-by: Jordan Ribbink <17958158+jribbink@users.noreply.github.com>
@mfbz mfbz requested a review from jribbink May 23, 2025 06:50
@mfbz mfbz merged commit 097840d into feature/typescript-fcl-core Jun 11, 2025
1 check passed
@mfbz mfbz deleted the mfbz/refactor-fcl-core-app-utils branch June 11, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants